Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Each position of geometry may include more than two elements #112

Closed
become-iron opened this issue Dec 1, 2018 · 4 comments
Closed

Each position of geometry may include more than two elements #112

become-iron opened this issue Dec 1, 2018 · 4 comments
Assignees
@become-iron
Labels
enhancement

Comments

@become-iron
Copy link
Contributor

become-iron commented Dec 1, 2018 •
edited
Loading

According to The GeoJSON Format description (Paragraph 3.1.1. Position) each position of geometry may include more than two elements. So checks for only two coordinates in components could be wrong.
For example, in point-geom validator: value => value.length === 2 probably should be validator: value => value.length >= 2
@ghettovoice
Copy link
Owner

Hi @become-iron,
thanks for clarify. I added this check to simplify things and forgot about it.

Can you made a pull request to fix this?

@become-iron
Copy link
Contributor Author

I created PR

@ghettovoice
Copy link
Owner

Thank! I'll merge it later

@ghettovoice
Copy link
Owner

Fixed by #114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@become-iron become-iron

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghettovoice @become-iron