Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): make sure we always have regex match array #271

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

ghiscoding
Copy link
Member

Description

improve code

Motivation and Context

avoid possible runtime failure by making sure all string ,match() returns an array

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #271 (6e884ab) into main (ac52574) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files         142      142           
  Lines        4101     4101           
  Branches      844      846    +2     
=======================================
  Hits         3848     3848           
  Misses        253      253           
Impacted Files Coverage Δ
packages/core/src/package.ts 99.38% <100.00%> (ø)
...ackages/version/src/lib/update-lockfile-version.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac52574...6e884ab. Read the comment docs.

@ghiscoding ghiscoding merged commit ba34849 into main Jul 24, 2022
@ghiscoding ghiscoding deleted the bugfix/regex-match-array branch July 24, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant