Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Movies when using other languages #46

Open
Druidblack opened this issue Jun 24, 2024 · 9 comments
Open

Missing Movies when using other languages #46

Druidblack opened this issue Jun 24, 2024 · 9 comments
Labels
bug Something isn't working

Comments

@Druidblack
Copy link

I started looking through the list of films "Movies everyone should watch at least once during their lifetime" and noticed that the films that are on the letterbox website are not in the list in the collection. Although I have a movie. For example https://letterboxd.com/film/come-and-see/
Безымянный

@ghomasHudson
Copy link
Owner

ghomasHudson commented Jun 24, 2024

Try adding imdb_id_filter: true under the letterboxd plugin config section. It'll be a lot slower but should be more accurate.

@Druidblack
Copy link
Author

Druidblack commented Jun 24, 2024

I added imdb_id_filter: true

This added an additional 3 films

Here is part of the log https://logs.notifiarr.com/?a10cb781adacfb32#J9jXDHh3YDUtQm7TYXfRf2gEphg1F4kvGFRCP1owdB2f

I don't understand the logic of how the plugin doesn't recognize movies.

I thought he was looking for a Come and See movie in English. And I have it in the fields name and original name written in the original language (Russian). But also the plugin does not find the movie Back to the Future, which I have and is named exactly as it is written in the log. Also with the Gremlins movie.

@Druidblack
Copy link
Author

1
2
3
4
Безымянный

@ghomasHudson
Copy link
Owner

I added imdb_id_filter: true

This added an additional 3 films

Here is part of the log https://logs.notifiarr.com/?a10cb781adacfb32#J9jXDHh3YDUtQm7TYXfRf2gEphg1F4kvGFRCP1owdB2f

I don't understand the logic of how the plugin doesn't recognize movies.

I thought he was looking for a Come and See movie in English. And I have it in the fields name and original name written in the original language (Russian). But also the plugin does not find the movie Back to the Future, which I have and is named exactly as it is written in the log. Also with the Gremlins movie.

Hmm it's quite hard to debug without knowing your exact library. I assume you're using a metadata provider in jellyfin and the imdb_ids are included in all your movies?

Beyond that, it's hard to know what to suggest - non-english languages could be part of the problem. If you're comfortable with python, try adding breakpoints in utils/jellyfin.py to work out where the query is failing.

@Druidblack
Copy link
Author

It's time to test your ideas. I checked on plugins for IMDB. The results are as follows.

  1. Plugins add movies to the collection not based on IMDB ID (tt000000), but based on the title. And it may differ by spaces, colons in the IMDB and TMDB databases. Therefore, not all films are added to the collection. I tried adding movies to the collection in the library language (in my case, in Russian). It got better. 128 films were added in English, 138 in Russian. (this is for the top 250).
    Is it possible to add a setting in which language to search in the plugin settings? Otherwise, I had to edit plugins in the docker container via the console.

@Druidblack
Copy link
Author

As an idea. Make an addition to the collection in two languages. Original and local. This way there is a better chance that more movies or TV series will end up in collections.

@Druidblack
Copy link
Author

I launched two containers, one with edits to search for movies in IMDB in Russian, the second container searches in English. Disabled list cleanup. As a result, the list collection (250 IMDB films) grew from 128 to 150 by searching in two languages.

@ghomasHudson
Copy link
Owner

Thanks for testing this out. I'll add a flag to allow setting the language for imdb search (potentially for multiple langauges). Have you managed to work out what's happening with the rest (if they're in your library)?

@Druidblack
Copy link
Author

I haven't looked yet at how many of those movies that are on the imdb list and I have don't get in. But it all comes down to names.
How is the search going now? Is the case taken into account when searching?

P.S. Make sure that the search is performed in two languages: English and the one that can be installed. This way there will be a better chance that the search will be more complete.

@ghomasHudson ghomasHudson changed the title The list of films "Movies everyone should watch at least once during their lifetime "is not complete Missing Movies when using other languages Aug 21, 2024
@ghomasHudson ghomasHudson added the bug Something isn't working label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants