Dependency on puppet-module-common

[benhocker]

I'm not sure what the proper fix for this is but master.pp does an "include common" on line 28 which causes the following error. Either add common as a dependency or don't use the common::mkdir_p to create passenger directories.

Debug: importing '/etc/puppet/modules/puppet/manifests/init.pp' in environment production
Debug: importing '/etc/puppet/modules/puppet/manifests/master.pp' in environment production
Debug: Automatically imported puppet::master from puppet/master into production
Warning: Config file /etc/puppet/hiera.yaml not found, using Hiera defaults
Debug: hiera(): Hiera YAML backend starting
Debug: hiera(): Looking up puppet::master::manage_firewall in YAML backend
Debug: hiera(): Looking for data source common
Debug: hiera(): Cannot find datafile /var/lib/hiera/common.yaml, skipping
Debug: hiera(): Looking up puppet::master::vhost_path in YAML backend
Debug: hiera(): Looking for data source common
Debug: hiera(): Cannot find datafile /var/lib/hiera/common.yaml, skipping
Debug: hiera(): Looking up puppet::master::rack_dir in YAML backend
Debug: hiera(): Looking for data source common
Debug: hiera(): Cannot find datafile /var/lib/hiera/common.yaml, skipping
Debug: hiera(): Looking up puppet::master::puppet_user in YAML backend
Debug: hiera(): Looking for data source common
Debug: hiera(): Cannot find datafile /var/lib/hiera/common.yaml, skipping
Debug: hiera(): Looking up puppet::master::sysconfig_path in YAML backend
Debug: hiera(): Looking for data source common
Debug: hiera(): Cannot find datafile /var/lib/hiera/common.yaml, skipping
Error: Could not find class common for sbox-puppet.fpd.cat.com on node sbox-puppet
/usr/lib/ruby/site_ruby/1.8/puppet/parser/compiler.rb:198:in `evaluate_classes'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/compiler.rb:181:in `each'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/compiler.rb:181:in `evaluate_classes'
/usr/lib/ruby/gems/1.8/gems/puppet-3.6.1/lib/puppet/parser/functions/include.rb:29:in `real_function_include'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/functions.rb:149:in `send'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/functions.rb:149:in `function_include'
/usr/lib/ruby/site_ruby/1.8/puppet/util/profiler/none.rb:6:in `profile'
/usr/lib/ruby/site_ruby/1.8/puppet/util/profiler.rb:43:in `profile'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/functions.rb:142:in `function_include'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/ast/function.rb:42:in `send'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/ast/function.rb:42:in `evaluate'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/ast.rb:61:in `safeevaluate'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/ast/block_expression.rb:11:in `evaluate'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/ast/block_expression.rb:10:in `each'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/ast/block_expression.rb:10:in `evaluate'
/usr/lib/ruby/site_ruby/1.8/puppet/parser/ast.rb:61:in `safeevaluate'
/usr/lib/ruby/site_ruby/1.8/puppet/resource/type.rb:122:in `evaluate_code'

If you comment out the common include, you will get this:

Error: Puppet::Parser::AST::Resource failed with error ArgumentError: Invalid resource type common::mkdir_p at /etc/puppet/modules/puppet/manifests/master.pp:78 on node sbox-puppet

[ghoneycutt]

Closing since we are having this conversation in PR #67