Refactor to allow booleans in parameters. #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch solves a lint issue where stringified booleans ('true'
instead of true) were used as default settings for parameter values.
Besides solving the lint issue, you can now safely pass booleans. This
also unearthed some issue with the spec tests and improves their
coverage.
ghoneycutt
added a commit
that referenced
this pull request
Jan 21, 2014
Refactor to allow booleans in parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch solves a lint issue where stringified booleans ('true'
instead of true) were used as default settings for parameter values.
Besides solving the lint issue, you can now safely pass booleans. This
also unearthed some issue with the spec tests and improves their
coverage.