Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adblocker-electron missing cjs build #242

Closed
char101 opened this issue Aug 7, 2019 · 4 comments · Fixed by #249
Closed

adblocker-electron missing cjs build #242

char101 opened this issue Aug 7, 2019 · 4 comments · Fixed by #249

Comments

@char101
Copy link

char101 commented Aug 7, 2019 •
edited
Loading

Hi,

There is no dist/cjs/adblocker.js in the npm package as specified in package.json main field. adblocker-electron version is 0.12.0.
@char101
Copy link
Author

char101 commented Aug 7, 2019 •
edited
Loading

Apparently the path in rollup.config.ts does not match with the path in package.json.

EDIT: sorry this is apparently for content.js.

@remusao
Copy link
Collaborator

remusao commented Aug 7, 2019

Hi @char101!

I could confirm this issue, I will be fixing this later today as well. Thanks again for taking the time to opening the issues today, that is very helpful.

Best,
Rémi

@char101
Copy link
Author

char101 commented Aug 7, 2019

Thanks for confirming the issue.

To clarify there are two missing files (1) the preload script in cjs/preload.js and (2) the module entry point in cjs/adblock.js.

@remusao remusao mentioned this issue Aug 7, 2019
Merged
@char101
Copy link
Author

char101 commented Aug 8, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

electron: fix bundles remusao/adblocker
2 participants
@char101 @remusao