Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adblocker-electron: constructor should pass arguments to super #246

Closed
char101 opened this issue Aug 7, 2019 · 4 comments · Fixed by #248
Closed

adblocker-electron: constructor should pass arguments to super #246

char101 opened this issue Aug 7, 2019 · 4 comments · Fixed by #248
Assignees

Comments

@char101
Copy link

char101 commented Aug 7, 2019

Otherwise the inherited parse static method is useless because it calls the parent constructor with the filters config.

@remusao
Copy link
Collaborator

remusao commented Aug 7, 2019

Hi again @char101,

Good point, the interface for all blockers should be unified, which means we should be able to pass all options to the ElectronBlocker class. I will be pushing a fix for this later today.

Thanks,
Rémi

@remusao remusao self-assigned this Aug 7, 2019
@char101
Copy link
Author

char101 commented Aug 7, 2019

Hi, other than the options, the result from parsing the filters is passed via the constructor, so it is really necessary for the proper functioning of the parse method.

@remusao
Copy link
Collaborator

remusao commented Aug 7, 2019

This should be fixed with #248

@char101
Copy link
Author

char101 commented Aug 8, 2019

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants