Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot serialize event due client #9

Closed
ghostzero opened this issue Oct 28, 2021 · 2 comments
Closed

Cannot serialize event due client #9

ghostzero opened this issue Oct 28, 2021 · 2 comments

Comments

@ghostzero
Copy link
Owner

ghostzero commented Oct 28, 2021

How to reproduce:

  1. Create a new tmi.php client.
  2. Recive an event via the tmi client.
  3. Serialize the given event.
  4. Error, because the serializer tries to serialize the $client property (which is a socket).

public Client $client;

@ghostzero
Copy link
Owner Author

For the records: Customer just serialize/unserialize the events before putting them into the queue. It would be awesome if tmi just serialize the classes by it's own. Eg. ignore the client in serialization, but then you cannot access client after unserialize 🤔

Hmm, complicated. It would be better to just remove client from the events.

@ghostzero
Copy link
Owner Author

Fixed in release 2.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant