Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement best practices for coredns app #2311

Closed
4 tasks done
Tracked by #2066
LolloneS opened this issue Apr 5, 2023 · 4 comments
Closed
4 tasks done
Tracked by #2066

Implement best practices for coredns app #2311

LolloneS opened this issue Apr 5, 2023 · 4 comments

Comments

@LolloneS
Copy link

LolloneS commented Apr 5, 2023

Coming from here.

The goal of this issue is to have the App eventually adhere to standard cloud-native best-practices. The points below are to be considered non-exhaustive. Feel free to add some that make sense and remove some that don't. If this issue does not make sense (e.g. is a duplicate or covers a deprecated app) please close it.

Expected outcome:

  • the app has properly set PDBs (as percentages)
  • the app can scale horizontally based on Custom Metrics (if it makes sense)
  • the app runs with more than 1 replica by default (if it needs HA)
  • the app does not use emptyDir volumes if not strictly necessary
@mcharriere
Copy link

mcharriere commented May 12, 2023

the app has properly set PDBs (as percentages)

This app already has PDB as percentages. Reviewing the chart I noticed that the PDB and the updateStrategy are using the same values for its configuration.

This is not really desired and could potentially cause problems. I created a PR to decouple the values, leaving PDB maxUnavailable in 25%.

@mcharriere
Copy link

mcharriere commented May 12, 2023

the app can scale horizontally based on Custom Metrics (if it makes sense)

I also added the option to use custom metrics for scaling in a new PR. Also created this issue https://github.com/giantswarm/giantswarm/issues/26942 for research, because scaling based on cluster size rather than usage might make more sense.

@mcharriere
Copy link

the app runs with more than 1 replica by default (if it needs HA)

It does already.

the app does not use emptyDir volumes if not strictly necessary

It does use emptyDir, and it seems to be well justified

@mcharriere
Copy link

released v1.17 with some improvements 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants