fix: wrapping command for fvm #130
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexushunter
reviewed
Jul 5, 2024
| @@ -21,11 +21,14 @@ class Command { | |||
| required String executable, | |||
| required List<String> arguments, | |||
| }) : this._( | |||
| executable == 'dart' || wrapper == Wrapper.none | |||
| wrapper == Wrapper.none | |||
There was a problem hiding this comment.
Why was this removed? This should short-circuit in the event that the dart command is being used. It is possible for the executable to be either a plain dart or flutter call 🤔 . We likely want to prevent configurations that have a wrapper applied to the dart command. TBH this could be clean up a bit to not have nested turneries.
| @@ -14,10 +14,10 @@ void main() { | |||
| expect(command.arguments, testArgs); | |||
| expect(command.executable, './flutterw'); | |||
| }); | |||
| test('Wrapper.fvw', () { | |||
| test('Wrapper.fvm', () { | |||
There was a problem hiding this comment.
Good catch on the typo :thankyou:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #129