Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dictionary switching button in /detail does not work #35

Open
trondtynnol opened this issue Apr 10, 2024 · 1 comment
Open

The dictionary switching button in /detail does not work #35

trondtynnol opened this issue Apr 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@trondtynnol
Copy link
Contributor

Feedback from a user of saan (but I believe this problem is a general one): When having clicked on a Skolt Saami word, say ǩiõččâd, and wanting to continue searching in the fin-sms dictionary, the user used the menu to the left of the search bar, but clicking on a different language pair did not actually change what dictionary was used.

The user had experienced this in Edge on Windows and Safari on a phone, and I have confirmed the behavior in both Firefox and Chromium on Linux.

@trondtynnol trondtynnol added the bug Something isn't working label Apr 10, 2024
@Phaqui
Copy link
Contributor

Phaqui commented Sep 3, 2024

Got another user report about this.

The dictionary selector dropdown right now does nothing, and I can't find the code for what it is supposed to do. I can find some code for handling the dropdown itself, but I can't see that it performs any kind of client-side work that would affect how the search bar on the same page behaves.

The search bar itself on the detailed results page works, but it takes you back to the "standard" search results page, you don't stay on the "detailed" search page, as one may or may not have expected. That's maybe a bit confusing.

Moreover, the dictionary selector dropdown contains the same functionality as the dictionary selector on the front page, presumably built as a simple dropdown just for the search bar on the details results page, which is also not ideal. How to switch dictionaries should be the same everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants