-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full Makefile #35
Comments
Feel free to send patches. |
This said automation is well possible. And running tests automatically would also be possible. We do in fact deploy this using Ansible on German Tileservers. |
Where can I have a look at that CI? Then I have a better idea what is needed. |
There is currently no CI. Frankly this is a one-man show kind of project so I do not think that a CI setup would solve any problems. |
@giggls Sorry if my tone may have sounded harsh, I did write this issue with the intention to write such a Makefile. I find it really helpful if everything that's needed for a project lives inside that project. |
I do not like the complexity of this stuff myself and already tried to reduce it. I already got rid of the lua pcre dependency. Unfortunately lua unnac is currently still needed and I'm afraid I will not get rid of this. Probably somebody can provide a pure lua implementation for this. |
I'd consider getting rid of all lua code. Removing accents can also be done with python unidecode (it's only a fallback so this should suffice plenty). Having to worry about two languages really multiplies problems understanding the whole project and so reduces potential contributions. The tests I would transfer to pytest (not unittest...). |
No, this is definitely a bad idea! Currently the python daemon is for transcription only and all decision logic is made in lua. This is not just for the sake of a clear task separation but also because of performance reasons as transcription is only the last resort in l10n while unaccent is done on almost any object. I do not like the usage of two scripting languages myself, but unfortunately I can not get rid of either one. |
@giggls Please have a look at #37 This builds successfully as seen at https://github.com/mkesper/osml10n/actions/runs/9114814291/job/25059657922 |
There should be a full, non-recursive Makefile installing dependencies and tools.
The README is much too handwavy and can not be tested automatically.
The text was updated successfully, but these errors were encountered: