From 27637cf3bd6ffb80986a0894c70508ea1130cbc1 Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Thu, 17 Aug 2017 12:11:31 +0300 Subject: [PATCH 01/46] Remove the unneeded `d-block` from `.carousel-item`s. (#23472) --- docs/4.0/examples/carousel/index.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/4.0/examples/carousel/index.html b/docs/4.0/examples/carousel/index.html index d6c220cb7f1b..7d4a6ea22b5a 100644 --- a/docs/4.0/examples/carousel/index.html +++ b/docs/4.0/examples/carousel/index.html @@ -51,7 +51,7 @@
First slide
-
+

Example headline.

Cras justo odio, dapibus ac facilisis in, egestas eget quam. Donec id elit non mi porta gravida at eget metus. Nullam id dolor id nibh ultricies vehicula ut id elit.

Sign up today

@@ -61,7 +61,7 @@

Example headline.

Second slide
-
+

Another example headline.

Cras justo odio, dapibus ac facilisis in, egestas eget quam. Donec id elit non mi porta gravida at eget metus. Nullam id dolor id nibh ultricies vehicula ut id elit.

Learn more

@@ -71,7 +71,7 @@

Another example headline.

Third slide
-
+

One more for good measure.

Cras justo odio, dapibus ac facilisis in, egestas eget quam. Donec id elit non mi porta gravida at eget metus. Nullam id dolor id nibh ultricies vehicula ut id elit.

Browse gallery

From a77f515a2228a11ae5815a76b7f3ba3b3bd17f1e Mon Sep 17 00:00:00 2001 From: Jonathan Berger Date: Thu, 17 Aug 2017 18:01:51 +0200 Subject: [PATCH 02/46] Fix error in Alerts component doc (#23522) --- docs/4.0/components/alerts.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/4.0/components/alerts.md b/docs/4.0/components/alerts.md index d3eb8bd18452..90c146362e36 100644 --- a/docs/4.0/components/alerts.md +++ b/docs/4.0/components/alerts.md @@ -8,7 +8,7 @@ toc: true ## Examples -Alerts are available for any length of text, as well as an optional dismiss button. For proper styling, use one of the four **required** contextual classes (e.g., `.alert-success`). For inline dismissal, use the [alerts jQuery plugin](#dismissing). +Alerts are available for any length of text, as well as an optional dismiss button. For proper styling, use one of the eight **required** contextual classes (e.g., `.alert-success`). For inline dismissal, use the [alerts jQuery plugin](#dismissing). {% example html %} {% for color in site.data.theme-colors %} From 58b54b6c15543dce3aca90e202037fa3b194f72e Mon Sep 17 00:00:00 2001 From: Johann-S Date: Thu, 17 Aug 2017 17:44:09 +0200 Subject: [PATCH 03/46] Carousel - do not call next when the carousel or the parent isn't visible --- js/src/carousel.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/js/src/carousel.js b/js/src/carousel.js index a5d5f143a497..27a8f7d3b82d 100644 --- a/js/src/carousel.js +++ b/js/src/carousel.js @@ -131,7 +131,9 @@ const Carousel = (($) => { nextWhenVisible() { // Don't call next when the page isn't visible - if (!document.hidden) { + // or the carousel or it's parent isn't visible + if (!document.hidden && + ($(this._element).is(':visible') && $(this._element).css('visibility') !== 'hidden')) { this.next() } } From d2bd8fb7a94906344d79669b74f3e432922d6b6f Mon Sep 17 00:00:00 2001 From: Johann-S Date: Thu, 17 Aug 2017 18:18:49 +0200 Subject: [PATCH 04/46] Unit test to check if our carousel do not cycle when we cannot see it --- js/tests/unit/carousel.js | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/js/tests/unit/carousel.js b/js/tests/unit/carousel.js index 894f78ab5139..cef4615761fc 100644 --- a/js/tests/unit/carousel.js +++ b/js/tests/unit/carousel.js @@ -842,4 +842,41 @@ $(function () { }) $textArea.trigger(eventKeyDown) }) + + QUnit.test('Should not go to the next item when the carousel is not visible', function (assert) { + assert.expect(2) + var done = assert.async() + var html = '