-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-joyride fails to compile (Next.js, webpack) #1072
Comments
It seems #1062 would resolve this issue |
Yeah, this library isn't compatible with React 19 yet. |
Any plans/estimations on React 19 compatibility? |
Any updates for this? |
It seems like @gilbarbara has other plans before updating this package to support React v19, which I disagree with but hey, I don't maintain nor contribute to this package 😅 But, in my opinion, React v19 should be prioritized since it is nearing release, and versions before 16.3 are being used less and less. One way to keep both parties happy is to do the v19 update and backport any new features @gilbarbara would like the React <16.3 folks to have. But supporting those legacy React versions is pretty pointless. Anywho, my workaround was to clone and build #1062 and add it as a package in my monorepo. Is it the best way? I don't know. Does it work? sure does! |
I've published a separate package in the meanwhile.
I hope we can find a way moving forward where we can support React 19 and still keep backwards compatibility in the original package. |
@cjkihl Amazing work! But do you mind updating the package? Thanks in advance :D |
@EliasVal You should use "use client" and next/dynamic with ssr: false on "react-joyride" My working example: then import exported consts as usual |
@kirill2400 Build still fails when trying your solution. |
@EliasVal I have two projects with Next.js 14.2.5 and 14.2.7 with react-joyride 2.9.2 and this code work perfectly
I can import or in any place in page and its worked. Can you say your versions? |
@kirill2400 I'm using Next.js canary (15.0.0-canary) which is probably why I can't get this to work. |
Sure. thank you for the reminder |
🐛 Bug Report
When trying to compile a Next.js app using
react-joyride
(React-rc, ReactDOM-rc, Next.js-canary), the build fails.To Reproduce
react-joyride
in a Next.js appExpected behavior
Normal build
Current behavior
Build fails with the following output:
System Information
The text was updated successfully, but these errors were encountered: