Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute unminified version as main #280

Closed
jayphelps opened this issue Nov 7, 2017 · 3 comments
Closed

Distribute unminified version as main #280

jayphelps opened this issue Nov 7, 2017 · 3 comments

Comments

@jayphelps
Copy link

Any objections to distributing the unminified version as the default for package.json "main" Bundlers like webpack won't pass-along source maps of dependencies by default, without something like source-map-loader, which requires forking/ejecting from create-react-app.

Noticed this because I'm trying to debug an issue related to joyride but it's very hard to figure out if it's my app (probably) or joyride itself.


Thanks for maintaining this library btw. It's awesome 🚀

@gilbarbara
Copy link
Owner

Hey,
Yeah, I can refactor the build process to transpile the individual files to /lib without uglifying and remove the source-map.

Thanks! :)

@gilbarbara
Copy link
Owner

@jayphelps Fixed!
Let me know if it worked.

[s]

@jayphelps
Copy link
Author

@gilbarbara works perfectly. Thank you much! 🕺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants