Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error (alert deprecated): Thread.kill #85

Open
rwmjones opened this issue Mar 1, 2021 · 1 comment · Fixed by ocaml/opam-repository#20514
Open

Error (alert deprecated): Thread.kill #85

rwmjones opened this issue Mar 1, 2021 · 1 comment · Fixed by ocaml/opam-repository#20514

Comments

@rwmjones
Copy link

rwmjones commented Mar 1, 2021

From: https://kojipkgs.fedoraproject.org//work/tasks/9111/62899111/build.log

+ dune build -j6
File "src/lib/ounit2/threads/oUnitRunnerThreads.ml", line 147, characters 8-19:
147 |         Thread.kill thread;
              ^^^^^^^^^^^
Error (alert deprecated): Thread.kill
Not implemented, do not use

I suspect this reflects some change in OCaml 4.12, since I cannot reproduce it with 4.11.x.
@rwmjones
Copy link
Author

rwmjones commented Mar 1, 2021

It seems related to this change in the compiler: ocaml/ocaml#9419

This was referenced Jan 22, 2022
Merged
Merged
mseri pushed a commit to ocaml/opam-repository that referenced this issue Jan 27, 2022
@gildor478
[new release] ounit2, ounit2-lwt, ounit and ounit-lwt (2.2.5)
a9b60bd 
CHANGES:

### Fixed
- Remove Thread.kill call, it was anyway not implemented and now it is
  officially deprecated. (Closes: gildor478/ounit#85)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[new release] ounit2, ounit2-lwt, ounit and ounit-lwt (2.2.5) gildor478/opam-repository
1 participant
@rwmjones