Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Context::new #253

Closed
philipc opened this issue Jul 14, 2022 · 1 comment · Fixed by #296
Closed

Remove Context::new #253

philipc opened this issue Jul 14, 2022 · 1 comment · Fixed by #296

Comments

@philipc
Copy link
Contributor

philipc commented Jul 14, 2022

The use of object in the public API means that breaking changes in object are breaking changes in this crate, and object necessarily has a large evolving API so breaking changes in it will continue to occur. It would be nice to avoid this.

A minor additional issue is that Context::new uses EndianRcSlice which isn't good for performance and memory usage.

Context::new is fairly small, and some of the major users of this crate already don't use it. If required, we could move it to a new crate. Such a crate may then even provide a higher level API, e.g. given a path to an executable, it could find the debug info using moria and load the file. This would address #110.

@philipc philipc mentioned this issue Jul 14, 2022
@philipc
Copy link
Contributor Author

philipc commented Apr 12, 2024

This is complicated because builtin_split_dwarf_loader depends on object now too, so it would have to move to a new crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant