Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement atomic operations for custom value types #65

Closed
gflegar opened this issue Jun 6, 2018 · 2 comments
Closed

Implement atomic operations for custom value types #65

gflegar opened this issue Jun 6, 2018 · 2 comments
Labels
is:bug Something looks wrong. is:confirmed Someone confirmed this issue. is:new-feature A request or implementation of a feature that does not exist yet. mod:cuda This is related to the CUDA module.

Comments

@gflegar
Copy link
Member

gflegar commented Jun 6, 2018

The current implementation of atomic operations (introduced in #57 and #64) does not support custom value types. Ginkgo will compile, but attempts of using it will result in assertions failures.

We should explore the possibility of general mutex functionalities for GPUs, which would allow us to implement atomics. They won't be extremely fast, but will at least work correctly.

@gflegar gflegar added is:bug Something looks wrong. is:new-feature A request or implementation of a feature that does not exist yet. is:confirmed Someone confirmed this issue. labels Jun 6, 2018
@gflegar gflegar added the mod:cuda This is related to the CUDA module. label Jun 28, 2018
@gflegar gflegar modified the milestone: Ginkgo 1.0.0 release Feb 12, 2019
@gflegar
Copy link
Member Author

gflegar commented Feb 12, 2019

This is to difficult to do for 1.0. Will have to wait.

@tcojean tcojean mentioned this issue Mar 5, 2019
36 tasks
@upsj
Copy link
Member

upsj commented Apr 20, 2021

It seems like this was already completed with #310, now unsupported types already fail at compile-time

@upsj upsj closed this as completed Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug Something looks wrong. is:confirmed Someone confirmed this issue. is:new-feature A request or implementation of a feature that does not exist yet. mod:cuda This is related to the CUDA module.
Projects
None yet
Development

No branches or pull requests

2 participants