HttpContext.ValidatePreconditions returns NoConditionsSpecified instead of AllConditionsMet when conditions pass

[cmeeren]

I think it might happen with ETag and If-Match, too.

Console app repro:

namespace Repro

open System
open Microsoft.AspNetCore.Http
open Giraffe

module Program =
  [<EntryPoint>]
  let main args =
    let ctx = DefaultHttpContext()
    ctx.Request.GetTypedHeaders().IfUnmodifiedSince <- Nullable(DateTimeOffset.Parse "Sat, 01 Jan 2000 00:00:00 GMT")
    Console.WriteLine("Should return ConditionFailed:")
    let result = ctx.ValidatePreconditions None (Some (DateTimeOffset.Parse "Sun, 02 Jan 2000 00:00:00 GMT"))
    Console.WriteLine(result)

    let ctx = DefaultHttpContext()
    ctx.Request.GetTypedHeaders().IfUnmodifiedSince <- Nullable(DateTimeOffset.Parse "Sat, 01 Jan 2000 00:00:00 GMT")
    Console.WriteLine("Should return AllConditionsMet:")
    let result = ctx.ValidatePreconditions None (Some (DateTimeOffset.Parse "Sat, 01 Jan 2000 00:00:00 GMT"))
    Console.WriteLine(result)

    0

Output:

Should return ConditionFailed:
ConditionFailed
Should return AllConditionsMet:
NoConditionsSpecified

[dustinmoris]

Thanks for raising this bug, I'll look into it!