Lets in toplevel let: shouldn't show loc, k and x in the Structure panel

[jfehrle]

plugin version: 0113-2023.1

Description

Was this perhaps intentional? It doesn't seems to show every let in functions. If I duplicate the x line, there are 2 entries for x in the structure panel.

[giraud]

I don’t understand the problem. It seems you are defining 3 inner variables loc, k and x: structure looks correct.
If you duplicate x, you will get two entries with x.
I am missing something.

[jfehrle]

I tweaked the description, which was poorly worded.

It's just that I don't expect the structure panel to show definitions of local variables. Not a bug, but my preference. If you want to show them, then shouldn't the function parameter 'fr' appear, too? Given that the structure panel opens all toplevel items automatically, the local variables distract me from what I'm most interested in seeing--the globals.

Is it really useful to show the assignments to record fields of ltacvars below? Also, the definitions are not in alpha or file order (I've set alpha order; they are in the correct order if I turn that off).

[giraud]

I agree that inner elements are too much, I’m not using them myself.
I believe it was implemented from a request but I can’t remember exactly. I thought that only one level of inner variables was shown.
also, normally the 'eye' icon should hide these inner definitions if disabled.
I will see why multiple levels are shown.

[giraud]

if not useful, I can remove the 'eye' icon and only top level definitions will be visible. would that 'fix' the bug ?

[jfehrle]

I was not aware of the eye icon, that hides the distracting info. GUIs are not really self-documenting, alas. So I would not spend time on this. User requests are sometime contradictory (across multiple users, though hopefully individual users are self-consistent :-).

[giraud]

ok, won’t fix then.
I have updated the code to keep only one level deep (removing record fields of inner let).