Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full version in git tags, or remove the build number from the artifacts to ensure they match #577

Closed
felipecrs opened this issue Dec 20, 2021 · 4 comments · Fixed by #638
Labels
enhancement New feature or request

Comments

@felipecrs
Copy link
Contributor

This would simplify a lot of scripts that automates the installation of GCM Core, especially on Linux. This is because, for any other project, it's common to use something like the following:

latest_version=$(basename "$(curl -fsSL -o /dev/null -w "%{url_effective}" https://github.com/docker/buildx/releases/latest)")

curl -fsSL "https://github.com/docker/buildx/releases/download/${latest_version}/buildx-${latest_version}.darwin-amd64"

But the problem of doing something similar with GCM Core is that the git tag does not match the version in the artifact name, and the build number is not guessable. I'm solving this issue by relying on a external service: https://github.com/Contextualist/glare

latest_version=$(basename "$(curl -fsSL -o /dev/null -w "%{url_effective}" https://github.com/GitCredentialManager/git-credential-manager/releases/latest)")

curl -fsSL "https://glare.vercel.app/GitCredentialManager/git-credential-manager@${latest_version}/gcmcore-linux_amd64.+.tar.gz$"

But it would be super cool if I could remove glare from the GCM Core installation flow.

This is especially a problem, because there is no way to use a APT repository and thus leveraging the version resolution to APT itself.

@felipecrs felipecrs added the enhancement New feature or request label Dec 20, 2021
@mjcheetham
Copy link
Collaborator

mjcheetham commented Mar 16, 2022

As mentioned in this issue, the new install from source script may work well for this scenario?

#447 (comment)

@felipecrs
Copy link
Contributor Author

felipecrs commented Mar 16, 2022

Not quite, it's not a good practice to rely on scripts available on the internet. All I need is to extract the .tar.gz to the correct folder anyway, so, it wasn't supposed to need a script for that.

In my specific case, I use chezmoi to manage my dotfiles, and I use its builtin feature of handling external archives to install my stuff from internet, so I have control over where and how they get installed.

Also, is there any reason why the request cannot be accommodated? It's seems very simple, I would be willing to submit a PR, I think.

I mean, what's the benefit of the current approach? What would we lose if we change the file names format from:

  • gcmcore-osx-2.0.632.34631.tar.gz

To simply:

  • gcmcore-osx-2.0.632.tar.gz

@ldennington
Copy link
Contributor

@felipecrs - thank you for your feedback. I agree that this would be a beneficial change, and we would welcome your contribution to make it happen 😊 .

@ldennington
Copy link
Contributor

@dscho - FYI that this change is happening (see #638). Please let us know if there's anything we can do to help out on the Git for Windows side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants