Skip to content

Commit

Permalink
windows: fix Repository>Explore Working Copy
Browse files Browse the repository at this point in the history
Since Git v2.39.1, we are a bit more stringent in searching the PATH. In
particular, we specifically require the `.exe` suffix.

However, the `Repository>Explore Working Copy` command asks for
`explorer.exe` to be found on the `PATH`, which _already_ has that
suffix.

Let's unstartle the PATH-finding logic about this scenario.

This fixes #4356

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
  • Loading branch information
dscho authored and Git for Windows Build Agent committed Oct 21, 2024
1 parent 8c29c98 commit 6325a0c
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions git-gui/git-gui.sh
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ proc _which {what args} {
if {[is_Windows] && [lsearch -exact $args -script] >= 0} {
set suffix {}
} elseif {[string match *$_search_exe $what]} {
# The search string already has the file extension
set suffix {}
} else {
set suffix $_search_exe
}
Expand Down

0 comments on commit 6325a0c

Please sign in to comment.