Git GUI: push, username dialog - asterisks when typing username #675

cztomczak · 2016-02-28T07:47:20Z

The username dialog shows asterisks when typing username. Asterisk hidden characters (*****) should be displayed when typing password. Not for username. When typing I saw asterisks and instantly deleted first characters of my username and started typing my password instead. Then the next dialog showed asterisks as well so I started typing my password again. Then a dialog appeared with error about wrong username/password - and it showed my password in plain-text. If there was a person sitting next to me he or she would know my password! And that's my secret, I definitely don't like this feature.

I was not able to find an open
or closed issue
matching what I'm seeing

Setup

Which version of Git for Windows are you using? 32-bit or 64-bit? Include the
output of git version as well.

32-bit.

$ git --version
git version 2.7.2.windows.1

Which version of Windows are you running? 32-bit or 64-bit?

64-bit. Win7 Pro SP1 .

What options did you set as part of the installation? Or did you choose the
defaults?

Defaults.

Any other interesting things about your environment that might be related
to the issue you're seeing?

No.

Details

Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Git GUI from context menu.

What commands did you run to trigger this issue? If you can provide a
Minimal, Complete, and Verifiable example
this will help us understand the issue.

from menu > remote > push

What did you expect to occur after running these commands?

To see a field to enter username.

When I type "cztomczak" i expect to see:

cztomczak

What actually happened instead?

When I type "cztomczak" i see in the field:

*******

If the problem was occurring with a specific repository, can you provide the
URL to that repository to help us with testing?

https://github.com/cztomczak/phpdesktop

The text was updated successfully, but these errors were encountered:

yaras · 2016-02-28T10:20:52Z

The username dialog shows asterisks when typing username. Asterisk hidden characters (*****) should be displayed when typing password. Not for username.

That's true.

I think the problem is in credential_getpass (credentials.c). I'll try to fix this issue next week and if I succeed I'll send a pull request with fix and I'll put comment here.

When user is asked for credentials there is no need to mask username, so PROMPT_ASKPASS flag on calling credential_ask_one for login is unnecessary. credential_ask_one internally uses git_prompt which in case of given flag PROMPT_ASKPASS uses masked input method instead of git_terminal_prompt, which does not mask user input. This fixes git-for-windows#675 Signed-off-by: yaras <yaras6@gmail.com>

When user is asked for credentials there is no need to mask username, so PROMPT_ASKPASS flag on calling credential_ask_one for login is unnecessary. credential_ask_one internally uses git_prompt which in case of given flag PROMPT_ASKPASS uses masked input method instead of git_terminal_prompt, which does not mask user input. This fixes #675 Signed-off-by: yaras <yaras6@gmail.com>

cztomczak · 2016-04-08T21:03:40Z

Just tested and it worked only on first push (a nice Windows credentials dialog appeared). When doing second push in a different GitHub repository I was presented with the old dialog with username input as asterisks. Attaching screenshot. Git version 2.7.3.windows.1 . Should this issue be reopened or a new issue be submitted?

dscho · 2016-04-11T10:15:36Z

You need to retest this with 2.8.1. My guess is that it will no longer be an issue because the Git Credential Manager is now enabled by default.

cztomczak · 2016-04-21T07:40:50Z

@dscho with 2.8.1 Windows Credentials window doesn't show anymore even on first push. I see a blank window with "Working... please wait..." for about 2 minutes and then the error "Fatal: TaskCancedledException" as seen on the screen above. Username is with asterisks.

Git version:

MINGW64 /c/github/cefpython (master)
$ git --version
git version 2.8.1.windows.1

This issue needs to be reopened.

EDIT:
I have installed git 2.8.1 with all defaults - Windows Credentials Manager was selected.
OS: Win 7 Pro SP1

dscho · 2016-04-21T08:12:21Z

This issue needs to be reopened.

Aren't you experiencing a totally different issue now?

cztomczak · 2016-04-21T09:11:51Z

@dscho Two issues: 1) two minute delay and TaskCancelException - a new issue 2) Asterisks in username - old issue

When user is asked for credentials there is no need to mask username, so PROMPT_ASKPASS flag on calling credential_ask_one for login is unnecessary. credential_ask_one internally uses git_prompt which in case of given flag PROMPT_ASKPASS uses masked input method instead of git_terminal_prompt, which does not mask user input. This fixes #675 Signed-off-by: yaras <yaras6@gmail.com>

When a user is asked for credentials there is no need to mask the username, so the PROMPT_ASKPASS flag on calling credential_ask_one for login is unnecessary. The `credential_ask_one()` function internally uses `git_prompt()` which in case it is given the flag PROMPT_ASKPASS uses masked input method instead of git_terminal_prompt, which does not mask user input. This fixes git-for-windows#675 Signed-off-by: Jarosław Honkis <yaras6@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

When user is asked for credentials there is no need to mask username, so PROMPT_ASKPASS flag on calling credential_ask_one for login is unnecessary. credential_ask_one internally uses git_prompt which in case of given flag PROMPT_ASKPASS uses masked input method instead of git_terminal_prompt, which does not mask user input. This fixes #675 Signed-off-by: yaras <yaras6@gmail.com>

yaras mentioned this issue Feb 29, 2016

Fixed masking username with asterisks when reading credentials #677

Merged

yaras self-assigned this Feb 29, 2016

dscho closed this as completed in #677 Mar 2, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Git GUI: push, username dialog - asterisks when typing username #675

Git GUI: push, username dialog - asterisks when typing username #675

cztomczak commented Feb 28, 2016

yaras commented Feb 28, 2016

cztomczak commented Apr 8, 2016

dscho commented Apr 11, 2016

cztomczak commented Apr 21, 2016 •

edited

Loading

dscho commented Apr 21, 2016

cztomczak commented Apr 21, 2016

Git GUI: push, username dialog - asterisks when typing username #675

Git GUI: push, username dialog - asterisks when typing username #675

Comments

cztomczak commented Feb 28, 2016

Setup

Details

yaras commented Feb 28, 2016

cztomczak commented Apr 8, 2016

dscho commented Apr 11, 2016

cztomczak commented Apr 21, 2016 • edited Loading

dscho commented Apr 21, 2016

cztomczak commented Apr 21, 2016

cztomczak commented Apr 21, 2016 •

edited

Loading