Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow add -p and add -i with a large number of files #305

Merged
merged 2 commits into from
Sep 12, 2015
Merged

Allow add -p and add -i with a large number of files #305

merged 2 commits into from
Sep 12, 2015

Conversation

dscho
Copy link
Member

@dscho dscho commented Aug 22, 2015

This fixes msysgit#182.

Inspired by Pull Request 218 using code from @PhilipDavis.

@dscho
Copy link
Member Author

dscho commented Aug 22, 2015

A test case to make sure that this really fixes an issue is still required, of course.

This was referenced Aug 22, 2015
Closed
Closed
Closed
@dscho dscho modified the milestone: Post-release cleanup Aug 24, 2015
@dscho dscho mentioned this pull request Aug 24, 2015
Closed
@dscho dscho force-pushed the msysgit_issues_182 branch 2 times, most recently from b350e7a to 9f609fe Compare September 12, 2015 11:02
kkheller and others added 2 commits September 12, 2015 11:36
@kkheller @dscho
Allow add -p and add -i with a large number of files
1834d85 
This fixes msysgit#182.

Inspired by Pull Request 218 using code from @PhilipDavis.

[jes: simplified code quite a bit]

Signed-off-by: Kelly Heller <kkheller@cedrus.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
t3701: verify that we can add *lots* of files interactively
5049df3 
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member Author

dscho commented Sep 12, 2015

I finally came up with a regression test. And of course it pointed to problems with the patch, which I have fixed now.

dscho added a commit that referenced this pull request Sep 12, 2015
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
0c51399 
Allow `add -p` and `add -i` with a large number of files
@dscho dscho merged commit 0c51399 into git-for-windows:master Sep 12, 2015
@dscho dscho deleted the msysgit_issues_182 branch September 12, 2015 11:44
dscho added a commit that referenced this pull request Sep 18, 2015
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
61756b9 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Sep 29, 2015
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
3b584d1 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Oct 5, 2015
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
a2448b9 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Oct 19, 2015
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
ccab258 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Nov 9, 2015
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
35b1673 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Dec 11, 2015
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
cf0aeb5 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Jan 5, 2016
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
9c92915 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Jan 28, 2016
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
a6893ff 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Feb 6, 2016
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
5a3bec5 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Feb 23, 2016
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
8d5f130 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Mar 15, 2016
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
6ed7500 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Mar 18, 2016
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
b9f7266 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request Mar 29, 2016
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
f7bbf9a 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 19, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
008ed3b 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 19, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
9214c4d 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 21, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
5fdfcd4 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 21, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
b255f47 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 21, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
d7aa19a 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 21, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
b3736a1 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 22, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
00d6229 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 22, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
df706e8 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 22, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
203efe4 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 22, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
cbc5708 
Allow `add -p` and `add -i` with a large number of files
dscho referenced this pull request in microsoft/git May 24, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
b927c96 
Allow `add -p` and `add -i` with a large number of files
dscho referenced this pull request in microsoft/git May 24, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
4c05e5d 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 25, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
b55c7a9 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 25, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
c54a4c5 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 25, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
fb64d9c 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 25, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
e342608 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 26, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
f3bea01 
Allow `add -p` and `add -i` with a large number of files
git-for-windows-ci pushed a commit that referenced this pull request May 28, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
288a428 
Allow `add -p` and `add -i` with a large number of files
dscho added a commit that referenced this pull request May 29, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
59cd775 
Allow `add -p` and `add -i` with a large number of files
git-for-windows-ci pushed a commit that referenced this pull request May 29, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
459cc38 
Allow `add -p` and `add -i` with a large number of files
git-for-windows-ci pushed a commit that referenced this pull request May 30, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
0dd615c 
Allow `add -p` and `add -i` with a large number of files
git-for-windows-ci pushed a commit that referenced this pull request May 30, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
b1f5159 
Allow `add -p` and `add -i` with a large number of files
git-for-windows-ci pushed a commit that referenced this pull request May 31, 2019
@dscho
Merge pull request #305 from dscho/msysgit_issues_182
0906f9e 
Allow `add -p` and `add -i` with a large number of files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Post-release cleanup
Development

Successfully merging this pull request may close these issues.

git add --interactive fails on subdir
2 participants
@dscho @kkheller