mingw: set $env:TERM=xterm-256color for newer OSes #3751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkitover
force-pushed
the
native-term
branch
2 times, most recently
from
04c635b to
528ed92
Compare
|
@dscho Hey, can you trigger the CI again please, it's giving me a fail on old code. |
dscho
requested changes
Mar 22, 2022
rkitover
force-pushed
the
native-term
branch
9 times, most recently
from
4dbb2fc to
f634351
Compare
|
@dscho In the interests of getting this fix out, I used your method, we can revisit the build number issue later. |
|
I tested this and it does work with the manifest. |
|
Hi @rkitover, you misspelled my username in your PR description, so I just saw this :) I think the fix makes sense: cmd and PowerShell do not set For completeness, you could mention the history of this part of the code, linking the commits mentioned in #3629, but I don't think it's necessary. Small nit: I would capitalize "Windows" in the commit message. |
For Windows builds >= 15063 set $env:TERM to "xterm-256color" instead of "cygwin" because they have a more capable console system that supports this. Also set $env:COLORTERM="truecolor" if unset. $env:TERM is initialized so that ANSI colors in color.c work, see 29a3963 (Win32: patch Windows environment on startup, 2012-01-15). See git-for-windows#3629 regarding problems caused by always setting $env:TERM="cygwin". This is the same heuristic used by the Cygwin runtime. Signed-off-by: Rafael Kitover <rkitover@gmail.com>
|
@phil-blain I've made these changes. |
|
@dscho Any objections to merging this as-is? This is literally your code, and the manifest issue is unrelated, this will work fine in the normal MINGW builds, I will try to deal with the manifest for VS builds later in a separate PR. Offtopic, on the other PR, I will make the changes as per your preferences as I've said, I've been distracted the past couple of weeks with feeling horrible and working on an issue in another project, but I will switch to this now. |
dscho
approved these changes
Apr 21, 2022
|
Thank you! And please forgive me that I could not take care of this PR sooner. |
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Apr 21, 2022
On newer Windows versions, Git [now assumes a Win32 Console with full color capabilities](git-for-windows/git#3751). This helps e.g. when NeoVIM is configured as Git's editor. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
that referenced
this pull request
Apr 26, 2022
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Apr 26, 2022
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Apr 26, 2022
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Apr 26, 2022
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Oct 11, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Oct 20, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Oct 20, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Oct 21, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 21, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 21, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 22, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Oct 23, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 25, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 25, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 25, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Oct 30, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 1, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 6, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Nov 22, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Nov 22, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Nov 22, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Nov 22, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
that referenced
this pull request
Nov 22, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
dscho
added a commit
to dscho/git
that referenced
this pull request
Nov 25, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
git-for-windows-ci
pushed a commit
that referenced
this pull request
Nov 25, 2024
mingw: set $env:TERM=xterm-256color for newer OSes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dscho @phil-blain @rimrul
Hi guys, this is half of my fix for #3629.
Once this is done I will try to fix quoting/escaping in
$env:EDITORwhich was the other problem there.