Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom theming support #3009

Closed
PavelLaptev opened this issue Mar 4, 2024 · 2 comments
Closed

Custom theming support #3009

PavelLaptev opened this issue Mar 4, 2024 · 2 comments
Assignees
Labels
enhancement An improvement to an existing feature UX/UI Focusing on user satisfaction, usability, and overall experience

Comments

@PavelLaptev
Copy link
Contributor

Right now, GitButler supports only two themes — dark and light.
It would be nice to support custom themes, e.g. support more presets or allow making fully custom via config.

image
@PavelLaptev PavelLaptev added enhancement An improvement to an existing feature UX/UI Focusing on user satisfaction, usability, and overall experience labels Mar 4, 2024
@PavelLaptev PavelLaptev self-assigned this Mar 4, 2024
@Qix-
Copy link
Contributor

Qix- commented Mar 4, 2024

If we implement #2932 then this should be a pretty trivial shuttling of information between that and the frontend. @PavelLaptev what do you think about having a fourth "Appearance" selection (from the screenshot in the OP) that is shown if you have a [theme] section in the config file?

We could have a base field that indicates if the CSS var overrides are based on the dark/light theme, and then the rest of the fields would be CSS vars we whitelist, shuttle that down to the frontend via a function/event (we can fswatch it for changes, too). Then the frontend just calls whatever.style.setProperty(--${varName}, varValue).

@PavelLaptev
Copy link
Contributor Author

@Qix- yes, that's should work 🙂

@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement to an existing feature UX/UI Focusing on user satisfaction, usability, and overall experience
Projects
Status: Done
Development

No branches or pull requests

2 participants