Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Users should be able to add to cart prior to connecting their wallet #93

Closed
meglister opened this issue Jul 2, 2024 · 3 comments

Comments

@meglister
Copy link
Member

Describe the bug
There is no add to cart button on the round homepage (eg - https://explorer-maci.gitcoin.co/#/round/11155111/346) or on the project page (https://explorer-maci.gitcoin.co/#/round/11155111/346/0xb543d56ee04f516602057429ec4f1c85c19b1319) before the user has connected their wallet.

To Reproduce
Load links above

Expected behavior
Add to cart button should be present in both places. A user should only be blocked on submitting a donation prior to connecting their wallet

Screenshots
n/a

Logs
n/a

Possible Solution
Add to cart should be supported

Additional context
n/a

@thelostone-mc
Copy link
Member

So the caveat here is that we would need to know the wallet address to know if the person has already voted.
Because if they've already voted -> we cannot allow them to add to cart and re-vote
This is expected behaviour. Will bring it up on standup to discuss other options

@nijoe1
Copy link
Collaborator

nijoe1 commented Jul 3, 2024

So the caveat here is that we would need to know the wallet address to know if the person has already voted. Because if they've already voted -> we cannot allow them to add to cart and re-vote This is expected behaviour. Will bring it up on standup to discuss other options

We can still show the add to cart btn but make it not clickable and include a tooltip on the btn "connect wallet" or when already contributed "you cannot contribute twice"

@thelostone-mc
Copy link
Member

Synced internally with team. Agreed that this is expected behaviour and not making any changes as of now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants