Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want to be prompted to authenticate before seeing a start work modal #1107

Closed
mbeacom opened this issue May 8, 2018 · 17 comments · Fixed by #1113
Closed

As a user, I want to be prompted to authenticate before seeing a start work modal #1107

mbeacom opened this issue May 8, 2018 · 17 comments · Fixed by #1113
Assignees
Labels
frontend This needs frontend expertise.

Comments

@mbeacom
Copy link
Contributor

mbeacom commented May 8, 2018

Currently, if a user is not logged into Gitcoin and they click on Start Work, they are still prompted with the start work modal. Once they submit the modal, they receive the notification that they must authenticate with Github.

We need to alert them to authenticate and redirect them to the FTUX if necessary.

start_work

Estimated Hours / Rate

1 Hour
$20 USD / hr

Reviewers

@PixelantDesign @vs77bb @owocki @mbeacom @thelostone-mc

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


This issue now has a funding of 0.028 ETH (20.5 USD @ $732.02/ETH) attached to it.

@gitcoinbot
Copy link
Member

gitcoinbot commented May 8, 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work has been started.

  1. @arun1595

has committed to working on this project to be completed 11 months, 4 weeks from now.

@bakaoh
Copy link
Contributor

bakaoh commented May 8, 2018

I think the 'start work' button should show 'login to start work' if user didn' t login

@thelostone-mc
Copy link
Member

@arun1595 when you get to it -> could you update the alert to use our custom alert aka
_alert({message: '....'}, 'error');

@arku
Copy link
Contributor

arku commented May 8, 2018

@thelostone-mc Sure!

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


Work for 0.028 ETH (20.95 USD @ $748.38/ETH) has been submitted by:

  1. @arun1595

@mbeacom please take a look at the submitted work:


@vs77bb vs77bb added this to the FTUX milestone May 9, 2018
@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Started 3. Submitted 4. Done


The funding of 0.028 ETH (20.47 USD @ $731.2/ETH) attached to this issue has been approved & issued to @arun1595.

@gopye
Copy link

gopye commented May 24, 2018

This issue should be automatically removed from https://gitcoin.co/explorer. Also doesn't look like these are updating correctly.
monosnap 2018-05-24 09-43-25

@owocki
Copy link
Contributor

owocki commented May 24, 2018

@mbeacom

did you open up a second bounty for this issue?

there seems to be two, and the second one is showing up on gitcoin -- thats why the gitcoin funded issue is showing as 'open'

https://beta.bounties.network/bounty/v1/383
https://beta.bounties.network/bounty/v1/483

@mbeacom
Copy link
Contributor Author

mbeacom commented May 24, 2018

@owocki Not that I'm aware of. The linked bounties seem to be for kennethashley and cryptotracker bounties?

@owocki
Copy link
Contributor

owocki commented May 24, 2018

is your metamask on the mainnet? this is what i see when i view them on the mainnet http://bits.owocki.com/1I3s451e3n0i/Screen%20Shot%202018-05-24%20at%2011.26.15%20AM.png

@owocki
Copy link
Contributor

owocki commented May 24, 2018

maybe one of your tx's got rebroadcast?

@mbeacom
Copy link
Contributor Author

mbeacom commented May 24, 2018

Whoops! Yeah... - This must have been the transaction that popped back up in my metamask interface to confirm. Ew...

@thelostone-mc
Copy link
Member

@weberV Looks like it's a script execution gone wrong ?
It's spammed all over the place.
Would you be kind enough to undo the changes and remove the comments across all our issues ?

Thanks in advance!

@gitcoinco gitcoinco deleted a comment May 26, 2018
@gokulkrishh
Copy link

@mbeacom Is this issue still open?? I can see it was opened back in gitcoin but closed here

@gomesalexandre
Copy link

gomesalexandre commented May 31, 2018

Issue still shows as opened on Gitcoin currently

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Cancelled


The funding of 0.028 ETH (16.12 USD @ $575.67/ETH) attached to this issue has been cancelled by the bounty submitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend This needs frontend expertise.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants