Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

as a website mantainer, i want a javascript widget that can show off my bounties, so i can lead more of my community to gitcoin #354

Closed
owocki opened this issue Jan 31, 2018 · 29 comments

Comments

@owocki
Copy link
Contributor

owocki commented Jan 31, 2018

what : a javascript widget (or image) that let me show off the bounties on my repos

please reuse the design from #644 , but implement it in javascript to be responsive instead of as an embedded image

37573585-266c9b1a-2adf-11e8-8484-50aced6a8bae

@owocki owocki added the to do label Jan 31, 2018
@owocki owocki changed the title as a website mantainer, i want a widget that can show off my bounties, so i can lead more of my community to gitcoin as a website mantainer, i want a javascript widget that can show off my bounties, so i can lead more of my community to gitcoin Mar 19, 2018
@gitcoinbot
Copy link
Member

This issue now has a funding of 0.15 ETH (81.17 USD @ $541.12/ETH) attached to it.

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $3119.82 more Funded OSS Work Available at: https://gitcoin.co/explorer

@maektwain
Copy link

Would like to work on this issue.

  1. PULL data from gitcoin api to show current bounties and fulfilled on the given bounty_owner_address.

Let me know if this is what we want.

@owocki
Copy link
Contributor Author

owocki commented Mar 22, 2018

@maektwain sorry im not sure i follow the question. are you asking if we can use the gitcoin api for this?

@matthewlilley
Copy link
Contributor

@owocki I've already done most of this, I'll try to finish it Today if possible, needs wiring up to the API and polish. It works in the same way as the Facebook embeddable like button, you can pass a gitcoin profile name. E.g.

<div id="gc-root" data-profile="MetaMask"></div>

Sound good?

@gitcoinbot
Copy link
Member

gitcoinbot commented Mar 24, 2018

Issue Status: 1. Open 2. Cancelled


Work has been started.

  1. @matthewlilley

has committed to working on this project to be completed 4 weeks ago.

@owocki, please see the below comments / questions regarding approach for this ticket from the bounty hunter(s):

@matthewlilley
Copy link
Contributor

@owocki I didn't manage to get to it on the weekend, but it's mostly complete. Needs some final integration, and a responsive friendly logo, srcset or svg.

https://stackblitz.com/edit/js-nkwz7t

@owocki
Copy link
Contributor Author

owocki commented Mar 26, 2018

wow this looks really good. thanks @matthewlilley !

  1. could we make each issue title (or each issue row) clickable?
  2. looks like the data is hard coded. needs to integrate the gitcoin api

cc @PixelantDesign in case she has comments on the design

@matthewlilley
Copy link
Contributor

@owocki No problem!

  1. & 2. Yes, it just needs plugging into your API, and a few minor details correcting. It'll probably be tomorrow now, it's been a long day.

M

@owocki
Copy link
Contributor Author

owocki commented Mar 28, 2018

& 2. Yes, it just needs plugging into your API, and a few minor details correcting. It'll probably be tomorrow now, it's been a long day.

coolio -- the api is pretty easy to use. docs are here =>

https://github.com/gitcoinco/web/blob/master/docs/API.md

feedback from a potential customer:

The recently funded issues—it’d be nice to show all open issues instead of recent issues. (Or, what’s defined as a “recent” issue?)

I do think this is a big improvement. The other design is a bit cluttered with info, kinda hard to understand when you first land on the page. This is nice and clear

@matthewlilley
Copy link
Contributor

Looks like some minor changes are needed to the API, a filter field for the org_name, and a simple limit. Okay for me to do a pull request those changes? Or if you have another suggestion, let me know.

"The recently funded issues—it’d be nice to show all open issues instead of recent issues. (Or, what’s defined as a “recent” issue?)"

Those issues could possibly be shown in a carousel style, so that you're not limited to the latest 4.

@matthewlilley
Copy link
Contributor

We could also add an option to the widget which would allow you to select recently funded, recently active etc... For a bit more flexibility.

@owocki
Copy link
Contributor Author

owocki commented Mar 30, 2018

you can just pass the org_name into the q field

eg https://gitcoin.co/explorer?q=Metamask_extension

@owocki
Copy link
Contributor Author

owocki commented Mar 30, 2018

Those issues could possibly be shown in a carousel style, so that you're not limited to the latest 4.

Love this idea! yes pls

We could also add an option to the widget which would allow you to select recently funded, recently active etc... For a bit more flexibility.

love this idea.. it could maybe be a javascript param in the widget definition?

@owocki
Copy link
Contributor Author

owocki commented Mar 30, 2018

!remind me when this is merged to respond back to colony => https://twitter.com/collinvine/status/979738374553591808

@matthewlilley
Copy link
Contributor

@owocki

Here's an updated version: https://stackblitz.com/edit/js-nkwz7t

With regards to the API usage, I'd expect to be able to do something like this:

https://gitcoin.co/api/v0.1/bounties/?org_name=MetaMask&limit=10

Right now that doesn't seem possible. I'll be happy to make a pull request.

Also, is there an SVG version of the logo available? If not, are the vector files available to export one?

Once we've got these couple of things sorted we can wrap this up.

@owocki
Copy link
Contributor Author

owocki commented Apr 4, 2018

there is a vector version of the logo availalbe at https://github.com/gitcoinco/creative -- but i dont know if it's SVG

https://gitcoin.co/api/v0.1/bounties/?org_name=MetaMask&limit=10

I just implemented the 'limit' param. Meantime, could you try using this? https://gitcoin.co/api/v0.1/bounties/?q=MetaMask&limit=10

@owocki
Copy link
Contributor Author

owocki commented Apr 4, 2018

91530d7 adds limit param

@PixelantDesign
Copy link
Contributor

Looking good @MadhuVaddi @matthewlilley!

Would it be possible to make a couple of updates?

  • Use Muli font
  • Sentence case on 'Recently funded issues'
  • Move 'Expires In' under each project name

Thanks!

@matthewlilley
Copy link
Contributor

@owocki Thanks!

@PixelantDesign Absolutely, I'll make those updates Today and get back to you.

@matthewlilley
Copy link
Contributor

@PixelantDesign Sorry, I thought I'd already replied to this. Can you take a look again here https://stackblitz.com/edit/js-nkwz7t

@gitcoinbot
Copy link
Member

@matthewlilley are you still working on this issue?

@PixelantDesign
Copy link
Contributor

Looks great @matthewlilley! Thank you!

@gitcoinbot
Copy link
Member

@matthewlilley are you still working on this issue?

@matthewlilley
Copy link
Contributor

@owocki, Would you like this included into the web repo, or a new sdk repo?

@owocki
Copy link
Contributor Author

owocki commented Apr 25, 2018

@matthewlilley maybe write up a markdown document showing off how to create the JS widget and PR it into https://github.com/gitcoinco/web/tree/master/docs ?

@matthewlilley
Copy link
Contributor

@owocki #989

@gitcoinbot
Copy link
Member

Issue Status: 1. Open 2. Cancelled


The funding of 0.15 ETH (103.66 USD @ $691.05/ETH) attached to this issue has been cancelled by the bounty submitter

@owocki
Copy link
Contributor Author

owocki commented May 17, 2018

paying this out via tip now

@gitcoinbot
Copy link
Member

⚡️ A tip worth 0.2 ETH (138.21 USD @ $691.05/ETH) has been granted to @matthewlilley for this issue from Kevin. ⚡️

The sender had the following public comments:

thx! this looks amazing

Nice work @matthewlilley! To redeem your tip, login to Gitcoin at https://gitcoin.co/explorer and select 'Claim Tip' from dropdown menu in the top right, or check your email for a link to the tip redemption page.

@gitcoinco gitcoinco deleted a comment May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants