-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gitcoinbot did not comment on github when work_done
event fired
#495
Comments
this just happened again on https://gitcoin.co/funding/details?url=https://github.com/MetaMask/metamask-extension/issues/2562 stacktrace i found in the logs
|
@owocki Do you think it's worth it to raise an issue on |
@mbeacom Looks like there is an ongoing issue being discussed at ethereum/web3.py#185 that looks similar Some workaround thoughts / ideas:
i am open to other suggestions here.. seems we will need to figure out a way to come up with reproduction steps before we can really submit a bug report upstream or fix the root cause. But I am on calls most of today and won't be able to get to that today. |
one other data point: i seem to be able to sync this bounty just fine on my local:
|
weird. it looks like the system is now editing old gitcoinbot comments with the payout comment, instead of submitting a new comment ? MetaMask/metamask-extension#2562 (comment) i was not aware of this! looks like this was your work https://github.com/gitcoinco/web/blame/master/app/dashboard/notifications.py#L325 -- my only concern about this is that it might not trigger an email back to the submitter letting them know they've been paid. |
@owocki I'll split off |
@mbeacom i'm not saying anything has to change.... just thinking out loud here... i was not aware of this.. maybe its better? im not sure |
looks like there is indeed no email when the comment is updated http://bits.owocki.com/3J3x1J0K2K0r/Screen%20Shot%202018-03-08%20at%204.22.24%20PM.png idk, im kind of leaning towards making approved/issue comment a new comment. what does everyone else think? @mbeacom @PixelantDesign ? |
ended up doing this |
https://gitcoin.co/funding/details?url=https://github.com/gitcoinco/web/issues/439
https://gitcoincommunity.slack.com/archives/C8DCUQU91/p1519617040000057
expected behaviour
when this bounty was marked as done, gitcoin bot should have updated the thread to tell everyone about it.
actual behaviour
an email was received, but no github comment appeared
The text was updated successfully, but these errors were encountered: