Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a pr list page #57

Merged
merged 10 commits into from
Oct 18, 2024
Merged

feat: add a pr list page #57

merged 10 commits into from
Oct 18, 2024

Conversation

gitcommitshow
Copy link
Owner

@gitcommitshow gitcommitshow commented Oct 9, 2024

  • List of open PRs
  • Group by user
  • Group by repo
  • Make the external contribution identification more robust

@gitcommitshow gitcommitshow added the enhancement New feature or request label Oct 9, 2024
@gitcommitshow
Copy link
Owner Author

Deterministic external user permission check returns error for repos where the app is not installed. This will lead to missing the PRs from the list which were external contribution in a repo where app was not installed.
This is not essential requirement but it will be good to have if we can also list those PRs.
Possible solutions

  1. If deterministic permission check throws error, show those PRs in a different list with "get head repo" button. On clicking the button, request the full PR details, which should finally confirm whether the PR is an external PR or not.

@gitcommitshow gitcommitshow mentioned this pull request Oct 16, 2024
@gitcommitshow gitcommitshow merged commit f152d39 into main Oct 18, 2024
@gitcommitshow gitcommitshow deleted the feat-pr-list branch October 18, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant