Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing for logos with larger heights #445

Closed
trinh opened this issue Nov 17, 2019 · 3 comments
Closed

Allowing for logos with larger heights #445

trinh opened this issue Nov 17, 2019 · 3 comments

Comments

@trinh
Copy link

trinh commented Nov 17, 2019

Is your feature request related to a problem? Please describe.

I've been trying to insert a 171px x 60px logo into the images/logo.png location. This is larger than the 32px allowance that seems to be embedded into the template. I tried to modify line 32 of navbar.php with:

$logo_size = 'height="60"';

but this doesn't seem to solve the issue, which is that the image is not centred on the top navbar.

Screen Shot 2019-11-17 at 21 38 23

I have tried to play with the navbar.php snippet

tpl_link(
                    $home_link,
                    '<img src="'.$logo.'" alt="'.$title.'" class="pull-left'.(($tagline) ? ' dw-logo-tagline' : '').'" id="dw__logo" '.$logo_size.' /> 
                    <span id="dw__title" '.($tagline ? 'style="margin-top:-5px"': '').'>'. $title . $tagline .'</span>',
                    'accesskey="h" title="[H]" class="navbar-brand"'
                );

but to be honest I do not understand what this section of code is doing.

Describe the solution you'd like

A simple code snippet that would centre the logos properly.

Describe alternatives you've considered

Anything helpful would be great!

@giterlizzi
Copy link
Owner

Hi,
in develop branch i have added the support of large logo (width > 32px).

Thanks for you good idea ;)

Joseph

@giterlizzi
Copy link
Owner

Header:

immagine

Footer:

immagine

@giterlizzi giterlizzi added this to the v2020-01 milestone Jan 20, 2020
@ThSGM
Copy link

ThSGM commented Jan 30, 2020

Hi!

I tried to download the development branch. Again, I used a logo with a larger size and modified line 46 to be:

if ($tagline) {
                    $logo_size = 'height="60"  style="margin-top:-5px"';
                }

instead of say, height = "32".

Can you walk me through how you managed to get the logo working? Is the newer developmental version supposed to automatically adjust based on the detected logo.png size or do we need to somehow configure it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants