New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`listRunners` Filter incorrect for Org Runners #884

Closed

mcaulifn opened this issue Jun 7, 2021 · 1 comment

Contributor

mcaulifn commented Jun 7, 2021

For org runners, the count is not checked correctly.

https://github.com/philips-labs/terraform-aws-github-runner/blob/develop/modules/runners/lambdas/runners/src/scale-runners/scale-up.ts#L57-L61
If repoName is empty, only environment is checked. The total runner count would be runners_maximum_count rather than each org.

Fixed in #871

The text was updated successfully, but these errors were encountered:

Contributor Author

mcaulifn commented Jun 15, 2021

should be resolved now that #871 is merged

mcaulifn closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment