You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This may be a good limit for GitHub, but I think that the library would be more widely useful if it was possible to change it—for example, via a getter/setter pair that accepted either a number or nil (to disable the check entirely).
A related issue is that when the limit is exceeded, Linguist returns an empty hash, which is the same as for an empty repository, with no indication of what happened. This can be quite confusing—or at least, it confused me the first time it happened, and issues #2915 and #3342 indicate that it has confused other people as well. Perhaps it could be changed to something that communicates the issue clearly, such as return :too_many_files or raise FileLimitExceededError?
The text was updated successfully, but these errors were encountered:
Currently, Linguist has a 100,000 file limit hardcoded in
lib/linguist/repository.rb
:When the number of files in the repository exceeds that, Linguist gives up and returns an empty result:
This may be a good limit for GitHub, but I think that the library would be more widely useful if it was possible to change it—for example, via a getter/setter pair that accepted either a number or
nil
(to disable the check entirely).A related issue is that when the limit is exceeded, Linguist returns an empty hash, which is the same as for an empty repository, with no indication of what happened. This can be quite confusing—or at least, it confused me the first time it happened, and issues #2915 and #3342 indicate that it has confused other people as well. Perhaps it could be changed to something that communicates the issue clearly, such as
return :too_many_files
orraise FileLimitExceededError
?The text was updated successfully, but these errors were encountered: