Add support for Turtle and SPARQL #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. The error you had was probably because you needed to regenerate the samples ( The grammar you propose to use doesn't have a license so I opened an issue on the repository: peta/turtle.tmbundle#11. Otherwise, every thing seems fine! 👍 |
|
There is now a license on the grammar's repository! @danmichaelo Could you update your pull request against master? It would ease the merge ;) |
|
sure! |
danmichaelo
force-pushed
the
turtle
branch
4 times, most recently
from
704ff62
to
994810f
Compare
|
Ok, so it's updated |
|
👍 - looks good. Thanks @danmichaelo and @pchaigno. This probably won't be live on GitHub for another couple of weeks. |
arfon
added a commit
that referenced
this pull request
Jan 15, 2015
Add support for Turtle and SPARQL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried adding support for Turtle and SPARQL. Got 3 errors when running the test suite both before and after adding my changes – at least the number of errors didn't increase :)
Extensions: