Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRs that didn't merge to the master are shown in #133

Closed
wellDan28 opened this issue Jan 30, 2018 · 8 comments
Closed

PRs that didn't merge to the master are shown in #133

wellDan28 opened this issue Jan 30, 2018 · 8 comments
Labels

Comments

@wellDan28
Copy link
Contributor

wellDan28 commented Jan 30, 2018

I've got a possible bug - I'm running gren by prs and the output contains prs that didn't merged to the master.
I'm expecting this prs to not be include in the release notes due the fact that they aren't part of the version.

@alexcanessa
Copy link
Member

@wellDan28 This might be a nice feature (more than a bug) to have an option to get only PRs coming from master.

@wellDan28
Copy link
Contributor Author

wellDan28 commented Jan 30, 2018

@alexcanessa just to make clear the PR was from a feature branch to the master but eventually was close without being merge to the master.
It seems that you can use the github api to check it https://developer.github.com/v3/pulls/#get-if-a-pull-request-has-been-merged

@alexcanessa
Copy link
Member

@wellDan28 Ohhhhh I see!

Ok definitely a bug then. Thanks!

@wellDan28
Copy link
Contributor Author

wellDan28 commented Feb 21, 2018

Can I give it a shot?

@alexcanessa
Copy link
Member

@wellDan28 sure!! 🏅

@wellDan28
Copy link
Contributor Author

@alexcanessa just want to update that I'm thinking of using the new graph api because it's easier and cleaner to use it. the v3 api doesn't let you filter by merged pr while you can do it in the graph api.

The only drawback I can see is that the project will have two clients for Github - v3 & graph.

@alexcanessa
Copy link
Member

alexcanessa commented Mar 13, 2018

@wellDan28 it would also solve this one #134 right?

@wellDan28
Copy link
Contributor Author

I think that #132 solved by #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants