Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the Changelog generator function #61

Closed
alexcanessa opened this issue Mar 24, 2017 · 5 comments
Closed

Rework the Changelog generator function #61

alexcanessa opened this issue Mar 24, 2017 · 5 comments

Comments

@alexcanessa
Copy link
Member

alexcanessa commented Mar 24, 2017

The changelog action now has some --override capacity which is not really needed.

What the changelog function should be responsible for should only be to update the current CHANGELOG.md using the existing releases.

  • The --override flag should only be able to override the latest release or a specific tag range.
  • Use the --tags=[] option to configure the release range too. optional
  • Would the changelog action be able to create release notes or should it just be based on the existing ones?
@alexcanessa
Copy link
Member Author

@DawoudIO would be good to have your feedback

@DawoudIO
Copy link

i like --tags[] for a subset of the logs
to me override is a full wipe of the old changelog.md
I'm not sure i understand the last comment about changelog

@crossan007 any feedback on the above items

@alexcanessa
Copy link
Member Author

@DawoudIO I was wondering if the --action=changelog should be able to create release notes from scratch or should just get the actual release notes (that could have been generated by this module) from Github.

@crossan007
Copy link

I like the idea of being able to create from scratch.

@crossan007
Copy link

+1 for --tags[]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants