-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking Change = New Major version #1708
Comments
Hi. Thanks for your report. I'm not sure if you saw #1703, but does that cover your breakage too, or do you suspect things broke for other reasons in your case? Please also see the perviously mentioned issue as to why this was not a major version bump. |
Thanks for your message, I'm still trying to work out why it doesn't work any more... at first I thought it was because of an update to the version of the SARIF format. |
Thanks for the update. Please let us know once you find the root cause or have any questions. |
Ok, the root cause was a some "Problem Exists Between Chair And Keyboard" because dev teams sound the alarm too fast... or maybe too late... or both... It appears that the v2.3.5 already solved the issue ! Sorry for disturbance :'( |
No worries and great that you've been able to track the problem down. I'm closing this issue now, as things seem to be resolved. |
Hello,
As long as you have updated the SARIF format file, the following do not work anymore using other solutions.
Some GitHub actions rely on:
And everything was fine until the v2.3.4
If there is breaking change, from my understanding, it must not keep the same Major version !
sysdiglabs/scan-action#30
The text was updated successfully, but these errors were encountered: