You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As noted in #2121 (comment) and #2117 (comment), check-spelling has special code to handle the case where a user thinks they can use security-events: ... to talk to sarif reporting, but they're in a private repository and that repository doesn't have GitHub Advanced Security enabled:
The codeql-action should have some code to handle this as well.
Ideally it'd do it in a way that is not fatal to actions/workflows that consume it.
check-spelling has to carefully decide not to call github/codeql-action today if it figures out that it'll fail, otherwise the action/workflow die because of this fault.
The text was updated successfully, but these errors were encountered:
Note: It'd be vaguely useful if the runner didn't actually give out a token for security-events if it wasn't allowed to because there wasn't a license -- that'd at least enable users to quickly recognize that there's a problem by looking at the top of the log. But that's outside the scope of this repository.
As noted in #2121 (comment) and #2117 (comment), check-spelling has special code to handle the case where a user thinks they can use
security-events: ...
to talk to sarif reporting, but they're in a private repository and that repository doesn't have GitHub Advanced Security enabled:https://github.com/check-spelling/check-spelling/blob/26b46adbdebd5dd0b34c7155113d50c40f43fb22/unknown-words.sh#L1610-L1618
https://github.com/check-spelling/check-spelling/blob/26b46adbdebd5dd0b34c7155113d50c40f43fb22/unknown-words.sh#L1122-L1126
Which results in this (more or less):
![image](https://private-user-images.githubusercontent.com/2119212/303460547-5ea9c4cd-f3df-4796-a266-0c9120881006.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzOTM4NjEsIm5iZiI6MTcyNDM5MzU2MSwicGF0aCI6Ii8yMTE5MjEyLzMwMzQ2MDU0Ny01ZWE5YzRjZC1mM2RmLTQ3OTYtYTI2Ni0wYzkxMjA4ODEwMDYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjNUMDYxMjQxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmQ5M2JkMWJhODAwMDFiNjZjMTQ3NzZiOWFjYjEyYjAyNmE0NTgyNGE3MTkxNjJlNDM2NzhkNGFiOGRlMGE4YSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.2y33ilkhDokFUnLwfrChr2-WLv8vBTJ0sKHT4Y5N1tE)
Check Spelling: .github/workflows/spelling.yml#L106
Unsupported configuration: use_sarif needs GitHub Advanced Security to be enabled - see https://docs.github.com/get-started/learning-about-github/about-github-advanced-security. (unsupported-configuration)
The codeql-action should have some code to handle this as well.
Ideally it'd do it in a way that is not fatal to actions/workflows that consume it.
check-spelling has to carefully decide not to call github/codeql-action today if it figures out that it'll fail, otherwise the action/workflow die because of this fault.
The text was updated successfully, but these errors were encountered: