From 909e2fd56a0e6b2bfe7cfc23eaa6298d24a49a07 Mon Sep 17 00:00:00 2001 From: Rasmus Wriedt Larsen Date: Mon, 15 Aug 2022 16:52:11 +0200 Subject: [PATCH 1/2] Disable python2 + pipenv tests Just like we did for poetry and Python 2 in https://github.com/github/codeql-action/pull/1124 From looking at changelogs, Python2 has not been supported in Pipenv since [v2021.11.5](https://pipenv.pypa.io/en/latest/changelog/#id149) --- .github/workflows/python-deps.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/python-deps.yml b/.github/workflows/python-deps.yml index 4a9ecbac0d..bba319384c 100644 --- a/.github/workflows/python-deps.yml +++ b/.github/workflows/python-deps.yml @@ -33,6 +33,9 @@ jobs: # Python2 and poetry are not supported. See https://github.com/actions/setup-python/issues/374 - python_version: 2 python_deps_type: poetry + # Python2 and pipenv are not supported since pipenv v2021.11.5 + - python_version: 2 + python_deps_type: pipenv env: @@ -135,6 +138,9 @@ jobs: # Python2 and poetry are not supported. See https://github.com/actions/setup-python/issues/374 - python_version: 2 python_deps_type: poetry + # Python2 and pipenv are not supported since pipenv v2021.11.5 + - python_version: 2 + python_deps_type: pipenv env: PYTHON_DEPS_TYPE: ${{ matrix.python_deps_type }} From c8cb2b45eb963b0fad2ed85851903fda49a789eb Mon Sep 17 00:00:00 2001 From: Rasmus Wriedt Larsen Date: Mon, 15 Aug 2022 16:56:44 +0200 Subject: [PATCH 2/2] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9f0348a1df..9423d1de2f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ - In debug mode, debug artifacts are now uploaded even if a step in the Actions workflow fails. [#1159](https://github.com/github/codeql-action/pull/1159) - Update default CodeQL bundle version to 2.10.3. [#1178](https://github.com/github/codeql-action/pull/1178) +- The combination of python2 and Pipenv is no longer supported. [#1181](https://github.com/github/codeql-action/pull/1181) ## 2.1.18 - 03 Aug 2022