-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: prepare debug artifacts for artifact
upgrades
#2475
Merged
Commits on Sep 11, 2024
-
Refactor: upload all available debug artifacts in init-post
Previously, we uploaded SARIF artifacts in the `analyze-post` step and database and log artifacts in the `init-post` step. As we migrate to the updated `artifact` dependencies, we want to switch to uploading all artifacts in one step. In order to upload all artifacts in one go and maintain the artifacts at the root of the debug directory, we first move SARIF artifacts to the database directory. This should not affect any other consumers of the SARIF file as this occurs in the `init-post` step.
Configuration menu - View commit details
-
Copy full SHA for b296f26 - Browse repository at this point
Copy the full SHA b296f26View commit details -
Only upload
upload-sarif
debug artifacts at most oncePreviously, we uploaded combined SARIF artifacts in both the `analyze-post` and `upload-sarif-post` steps. This change ensures that these artifacts are uploaded at most once — in `analyze-post` if it is a first-party run and `upload-sarif-post` if it is a third-party run. This is a defensive check because as we upgrade to the new `artifact` dependencies we will not be able to upload artifacts to the same artifact directory.
Configuration menu - View commit details
-
Copy full SHA for c098b25 - Browse repository at this point
Copy the full SHA c098b25View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ba2440 - Browse repository at this point
Copy the full SHA 4ba2440View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82ce313 - Browse repository at this point
Copy the full SHA 82ce313View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4bfd40 - Browse repository at this point
Copy the full SHA d4bfd40View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cb7faf5 - Browse repository at this point
Copy the full SHA cb7faf5View commit details -
Rename
upload-debug-artifacts
tocombined-sarif-artifacts
More accurately describes what these artifacts are, rather than the step they're uploaded in.
Configuration menu - View commit details
-
Copy full SHA for e771680 - Browse repository at this point
Copy the full SHA e771680View commit details -
Configuration menu - View commit details
-
Copy full SHA for bc660fc - Browse repository at this point
Copy the full SHA bc660fcView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.