Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: prepare debug artifacts for artifact upgrades #2475

Merged
merged 8 commits into from
Sep 13, 2024

Commits on Sep 11, 2024

  1. Refactor: upload all available debug artifacts in init-post

    Previously, we uploaded SARIF artifacts in the `analyze-post` step and database and log artifacts in the `init-post` step. As we migrate to the updated `artifact` dependencies, we want to switch to uploading all artifacts in one step.
    
    In order to upload all artifacts in one go and maintain the artifacts at the root of the debug directory, we first move SARIF artifacts to the database directory. This should not affect any other consumers of the SARIF file as this occurs in the `init-post` step.
    angelapwen committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b296f26 View commit details
    Browse the repository at this point in the history
  2. Only upload upload-sarif debug artifacts at most once

    Previously, we uploaded combined SARIF artifacts in both the `analyze-post` and `upload-sarif-post` steps. This change ensures that these artifacts are uploaded at most once — in `analyze-post` if it is a first-party run and `upload-sarif-post` if it is a third-party run.
    
    This is a defensive check because as we upgrade to the new `artifact` dependencies we will not be able to upload artifacts to the same artifact directory.
    angelapwen committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c098b25 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4ba2440 View commit details
    Browse the repository at this point in the history
  4. Remove unused helper file

    angelapwen committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    82ce313 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d4bfd40 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    cb7faf5 View commit details
    Browse the repository at this point in the history
  2. Rename upload-debug-artifacts to combined-sarif-artifacts

    More accurately describes what these artifacts are, rather than the step they're uploaded in.
    angelapwen committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    e771680 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc660fc View commit details
    Browse the repository at this point in the history