Check zstd is on the path in addition to tar version #2526
Conversation
| "Failed to determine tar version, therefore will assume zstd may not be available. " + | ||
| `The underlying error was: ${e}`, | ||
| ); | ||
| return { available: false }; | ||
| return { available: false, foundZstdBinary }; |
There was a problem hiding this comment.
What's the use case for knowing if zstd is available if we can't figure out what tar version is available?
Actually, I'm not sure what the use case for having foundZstdBinary as part of the interface is. Is this for telemetry?
There was a problem hiding this comment.
What's the use case for knowing if zstd is available if we can't figure out what tar version is available?
If we can't figure out what tar version is available, we want to fall back to gzip.
Actually, I'm not sure what the use case for having
foundZstdBinaryas part of the interface is. Is this for telemetry?
Yes, this is just to help us understand how much of the time zstd wasn't available due to the tar version and how much of the time it wasn't available due to not being able to find a zstd binary.
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
|
Pushed a commit to rebuild the Action. Please mark the PR as ready for review to trigger PR checks. |
| "Failed to determine tar version, therefore will assume zstd may not be available. " + | ||
| `The underlying error was: ${e}`, | ||
| ); | ||
| return { available: false }; | ||
| return { available: false, foundZstdBinary }; |
tarcalls out tozstdto decompress a.tar.zst, so we should check thezstdbinary is accessible as part of determining whether to download a.tar.zstbundle.Merge / deployment checklist