Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank lines inside conditional blocks preventing contained blockquotes from properly joining to a top blockquote. #35364

Closed
1 task done
Skenvy opened this issue Nov 20, 2024 · 4 comments · Fixed by #35365
Closed
1 task done
Labels
account-and-profile Content relating to account and profile content This issue or pull request belongs to the Docs Content team

Comments

@Skenvy
Copy link
Contributor

Skenvy commented Nov 20, 2024

Code of Conduct

What article on docs.github.com is affected?

https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-your-personal-account/merging-multiple-personal-accounts
image

What changes are you suggesting?

The existing markdown

> [!TIP]
{% ifversion ghec %}

> Some text

{% else %}

> Some other text

{% endif %}

Produces an empty TIP block, followed by a disconnected quote block.

Removing the spaces, or duplicating the top TIP line into both blocks, should make this appear as it would seem to be intended: that the following quotes are part of the TIP block.

Additional information

No response

@Skenvy Skenvy added the content This issue or pull request belongs to the Docs Content team label Nov 20, 2024
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 20, 2024
@akordowski
Copy link
Contributor

@Skenvy Thank you for pointing it out. I provided a PR to fix this.

@nguyenalex836
Copy link
Contributor

@akordowski 👋 Since @Skenvy found this issue and has also opened a PR to address this, I'll be merging their PR 💛 Thank you for be willing to fix this!

@nguyenalex836 nguyenalex836 added account-and-profile Content relating to account and profile and removed triage Do not begin working on this issue until triaged by the team labels Nov 20, 2024
@akordowski
Copy link
Contributor

@nguyenalex836 Ok, haven't seen the PR 🫣

@nguyenalex836
Copy link
Contributor

@akordowski No worries at all! It doesn't look like it was linked before, but now I've linked it to this issue 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account-and-profile Content relating to account and profile content This issue or pull request belongs to the Docs Content team
Projects
None yet
3 participants