Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code scanning: only repo admins can now delete alerts #745

Closed
hubwriter opened this issue Oct 23, 2020 · 2 comments
Closed

Code scanning: only repo admins can now delete alerts #745

hubwriter opened this issue Oct 23, 2020 · 2 comments
Labels
content This issue or pull request belongs to the Docs Content team good first issue Good for newcomers triage Do not begin working on this issue until triaged by the team

Comments

@hubwriter
Copy link
Contributor

What feature or product is affected?

Code scanning. Docs on "Dismissing or deleting alerts."

What is the new or expected behavior?

The behaviour has just been changed so that only repository admins can delete code scanning alerts. Other users who have write permission to the repo, and can therefore see the alerts summary list, won't see the Delete button:

image

How is the old or inaccurate behavior currently documented?

The documentation doesn't currently state that you have to be a repository admin to delete alerts. Non-admin users with write permission to the repo might wonder why they are not seeing the Delete button shown in the screenshot in step 4 of "Dismissing or deleting alerts."

This just requires a couple of additions to explain this prerequisite.

In the introductory paragraph of this section, change:

Alternatively, you can delete alerts.

to:

Alternatively, if you have admin permission for the repository, you can delete alerts.

In step 4 of the section, change:

If you want to delete alerts for this code scanning tool

to:

If you have admin permission for the repository, and you want to delete alerts for this code scanning tool

@hubwriter hubwriter added good first issue Good for newcomers content This issue or pull request belongs to the Docs Content team labels Oct 23, 2020
@welcome
Copy link

welcome bot commented Oct 23, 2020

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 23, 2020
@hubwriter
Copy link
Contributor Author

Now fixed.
#760 closes this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team good first issue Good for newcomers triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

No branches or pull requests

1 participant