-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Autofixing renamed/removed collection items ✨ #4432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command resultsDetails:add path/home/runner/work/_actions/technote-space/create-pr-action/v2/node_modules/npm-check-updates/build/src/bin bundle exec rake collectionsRun options: --seed 55265
# Running:
..............................................................................................
Finished in 59.742452s, 1.5734 runs/s, 0.0000 assertions/s.
94 runs, 0 assertions, 0 failures, 0 errors, 0 skips stderr:To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
To use multipart middleware with Faraday v2.0+, install `faraday-multipart` gem; note: this is used by the ManageGHES client for uploading licenses
Repo api was called 0 times!
User api was called 0 times! Changed filesChanged file:
|
kenyonj
approved these changes
Aug 22, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ahpook
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jmeridth thanks for moving these, but this test just has a hard time handling renames, i usually just force-merge these. |
Yeah. Realized the move didn't help. I'm good with a merge. |
evilaliv3
pushed a commit
to evilaliv3/explore
that referenced
this pull request
Sep 11, 2024
* ✨ Autofixing renamed/removed collection items ✨ * ✨ Autofixing renamed/removed collection items ✨ * fix: move changed items in collections to end of list (append) Signed-off-by: jmeridth <jmeridth@gmail.com> --------- Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Justin Kenyon <kenyonj@github.com> Co-authored-by: Jason Meridth <jmeridth@github.com> Co-authored-by: jmeridth <jmeridth@gmail.com>
evilaliv3
pushed a commit
to evilaliv3/explore
that referenced
this pull request
Sep 11, 2024
* ✨ Autofixing renamed/removed collection items ✨ * ✨ Autofixing renamed/removed collection items ✨ * fix: move changed items in collections to end of list (append) Signed-off-by: jmeridth <jmeridth@gmail.com> --------- Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Justin Kenyon <kenyonj@github.com> Co-authored-by: Jason Meridth <jmeridth@github.com> Co-authored-by: jmeridth <jmeridth@gmail.com>
evilaliv3
pushed a commit
to evilaliv3/explore
that referenced
this pull request
Sep 17, 2024
* ✨ Autofixing renamed/removed collection items ✨ * ✨ Autofixing renamed/removed collection items ✨ * fix: move changed items in collections to end of list (append) Signed-off-by: jmeridth <jmeridth@gmail.com> --------- Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: GitHub Actions <actions@github.com> Co-authored-by: Justin Kenyon <kenyonj@github.com> Co-authored-by: Jason Meridth <jmeridth@github.com> Co-authored-by: jmeridth <jmeridth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base PullRequest
default branch (https://github.com/github/explore/tree/main)
Command results
Details:
add path
bundle exec rake collections
stderr:
Changed files
Changed file:
Repo | 📝 Issues | 🏬 Marketplace