Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Pyxel game engine #4507

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Removed Pyxel game engine #4507

merged 3 commits into from
Nov 5, 2024

Conversation

AdamHarte
Copy link
Contributor

Please confirm this pull request meets the following requirements:

Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Editing an existing topic or collection

I'm suggesting these edits to an existing topic or collection:

  • Image (and my file is *.png, square, dimensions 288x288, size <= 75 kB)
  • Content (and my changes are in index.md)

Looks like the Pyxel game engine was mistaken for the PyxelEdit pixel art software, which is not opensource. So I removed it, as the game engine is not a "Pixel Art Tool".


Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.

@AdamHarte AdamHarte requested a review from a team as a code owner November 3, 2024 21:09
@AdamHarte
Copy link
Contributor Author

AdamHarte commented Nov 4, 2024

Failing tests because:

Error: expected collection changes to have been appended to the existing item list

Seems like a bad test, because not all changes are additions. Does this mean that nobody can ever remove items?

@jmeridth
Copy link
Member

jmeridth commented Nov 5, 2024

Failing tests because:

Error: expected collection changes to have been appended to the existing item list

Seems like a bad test, because not all changes are additions. Does this mean that nobody can ever remove items?

@AdamHarte That's a fair statement. I'm good to merge this and then let the collection action generate the PR that will make this happy. Chicken/egg. I will take a look at it soon to hopefully allow just deletions with no issues.

@jmeridth jmeridth merged commit 28a0329 into github:main Nov 5, 2024
4 of 5 checks passed
@jmeridth
Copy link
Member

jmeridth commented Nov 5, 2024

@AdamHarte thank you for helping us keep these collections clean. 🙇

@AdamHarte
Copy link
Contributor Author

@jmeridth No worries at all. Thank you for sorting this out. I was starting to get worried I was not going to be able to get this change through. :)

@AdamHarte AdamHarte deleted the patch-1 branch November 5, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants