Align used flag error message to Chrome's implementation #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing the error message was added in #10 to make sure it was failing for the right reason. I'm fine with removing that assertion and just relying on testing the error for |
|
Error messages are never specced since they can vary in different locales, browsers, etc. |
|
Alright, I'm just going to drop those assertions. But I still changed our error message to match Chromes. |
josh
added a commit
that referenced
this pull request
Dec 19, 2014
Align used flag error message to Chrome's implementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome experimental
fetch()implementation throws the correctTypeErrorbut with a"Already read"message.The spec doesn't define what the error message should exactly be. Maybe we shouldn't be testing it?
/cc @dgraham @annevk
Related #41.