Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron emoji #128

Closed
Crissov opened this issue Jun 3, 2017 · 2 comments · Fixed by #158
Closed

Electron emoji #128

Crissov opened this issue Jun 3, 2017 · 2 comments · Fixed by #158

Comments

@Crissov
Copy link

Crissov commented Jun 3, 2017 •
edited
Loading

It does not seem to be documented in this repository, but somehow Github seems to support non-standard electron and atom emojis :electron: :atom: for the respective products. They should probably be dealt with the same as other extensions like octocat :octocat:. The same goes, of course, for any other "emojis" I'm not yet aware of.
@mislav
Copy link
Contributor

mislav commented Jun 5, 2017

Are you suggesting that we import these two custom emoji so they ship with the gemoji project?

@Crissov
Copy link
Author

Crissov commented Jun 5, 2017 •
edited
Loading

I'd rather see no "custom emojis" in gemoji at all, but being maintained by GitHub I thought one of its points was to document and make available all of them.

IOW, why would Octocat be included if Electron and Atom aren't?

@mislav mislav mentioned this issue May 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove custom emoji github/gemoji
2 participants
@mislav @Crissov