Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrator status should be sent to migrationContext logger #1026

Closed
SocalNick opened this issue Sep 17, 2021 · 1 comment
Closed

Migrator status should be sent to migrationContext logger #1026

SocalNick opened this issue Sep 17, 2021 · 1 comment

Comments

@SocalNick
Copy link
Contributor

We contributed a logging interface a while back in #789, unfortunately, it still took us a while to get back to using GitHub/gh-ost rather than our fork in our project. One of our users just pointed out they didn't see progress indicators. Turns out we missed this from our fork, we used to send the status messages through the migrationContext logger in addition to stdout.

I will submit a PR for this, thanks in advance for your consideration!
@SocalNick SocalNick mentioned this issue Sep 17, 2021
Closed
2 tasks
@Luimoll Luimoll mentioned this issue Oct 1, 2021
Closed
This was referenced Oct 27, 2022
Closed
Merged
@dm-2
Copy link
Contributor

dm-2 commented Nov 14, 2022

👋 @SocalNick Thanks for the PRs!

I like the simplicity of #1194, so I think this is the one to go for - I've run CI, and approved and merged the PR 🚀

Thanks again for your contribution!

@dm-2 dm-2 closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SocalNick @dm-2 and others