Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Beluga language #4400

Closed
wants to merge 7 commits into from
Closed

Added Beluga language #4400

wants to merge 7 commits into from

Conversation

marcelgoh
Copy link

@marcelgoh marcelgoh commented Feb 3, 2019

Adding support for Beluga, a functional programming language designed for reasoning about formal systems.

Description

Added grammar files, samples, and added Beluga to list of languages.

Checklist:

  • I am adding a new language.
    • The extension of the new language is used in hundreds of repositories on github.com.
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
      • Sample license(s):
    • I have included a syntax highlighting grammar: Link to Lightshow
    • I have updated the heuristics to distinguish my language from others using the same extension.

@marcelgoh
Copy link
Author

marcelgoh commented Feb 3, 2019

EDIT: I have fixed the problem. It appears I forgot to add Beluga to languages.yml. I apologise for the needlessly many commits.

After the original submission, I fixed as many issues as I could but the build still gets an error saying that no language was found for sample Beluga files I added. Would there be a simple fix for this?

@pchaigno
Copy link
Contributor

pchaigno commented Feb 3, 2019

I apologise for the needlessly many commits.

No worries. We're going to squash them at merge-time anyway.

Would there be a simple fix for this?

Yes, you need to add a real-world usage sample as per the contribution guidelines.

@marcelgoh
Copy link
Author

marcelgoh commented Feb 3, 2019

I apologise for the needlessly many commits.

No worries. We're going to squash them at merge-time anyway.

Would there be a simple fix for this?

Yes, you need to add a real-world usage sample as per the contribution guidelines.

EDIT: I realise I forgot to add the samples to the actual pull request. I have updated the original checklist. Please do let me know of anything else I might be missing!

Hi! Thanks for considering my pull request! I think I managed to fix the problems I had earlier and the most recent commit seems to build.

@marcelgoh
Copy link
Author

Would it be possible to add a colour for Beluga, as it is a programming language? What is the best way to choose a colour that doesn't conflict with others? I wasn't sure so I left it blank.

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Harvester and the search query you provided, I counted only 12 repositories among 10 users. That is not enough to meet our usage requirement of hundreds of repositories.

How old is Beluga? Are there any reason to believe usage will increase exponentially in the next months?

@marcelgoh
Copy link
Author

Using Harvester and the search query you provided, I counted only 12 repositories among 10 users. That is not enough to meet our usage requirement of hundreds of repositories.

How old is Beluga? Are there any reason to believe usage will increase exponentially in the next months?

Work on Beluga has been ongoing since 2009. While the current usage is not enormous, I believe that exposure for Beluga will only increase in the future, as more and more languages incorporate features that the creators of Beluga have been working on (e.g. dependent types, contexts). And because the .bel extension is not used by any other programming languages, I thought it would be a safe addition to GitHub's languages.

@pchaigno
Copy link
Contributor

pchaigno commented Feb 5, 2019

Okay. Let's reopen this pull request once usage is in the hundreds. Don't hesitate to ping me if you think we're there and would like me to run Harvester again.

And because the .bel extension is not used by any other programming languages, I thought it would be a safe addition to GitHub's languages.

That requirement stands for all extensions and languages, regardless of conflicts. If the extension was .beluga I might be less wary of adding it and would likely require less repositories than usual. But there's also a maintenance cost to any new extension and any new language, and we have to take that into account.

@pchaigno pchaigno closed this Feb 5, 2019
@marcelgoh
Copy link
Author

Okay. Let's reopen this pull request once usage is in the hundreds. Don't hesitate to ping me if you think we're there and would like me to run Harvester again.

Sounds good. Thanks for the help!!

@Arcensoth Arcensoth mentioned this pull request Feb 17, 2019
4 tasks
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants